This is an automated email from the ASF dual-hosted git repository. davsclaus pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/camel.git
commit 4a023d853a5d9e30e444e3fcf698f12ed2c68c96 Author: Claus Ibsen <[email protected]> AuthorDate: Mon Jan 13 22:08:09 2025 +0100 CAMEL-21615: camel-jbang - Nicer error when export without name or gav --- .../org/apache/camel/dsl/jbang/core/commands/Export.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Export.java b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Export.java index efbc89f669d..ac095731f85 100644 --- a/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Export.java +++ b/dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Export.java @@ -24,7 +24,6 @@ import java.util.Comparator; import java.util.Date; import java.util.Properties; -import org.apache.camel.RuntimeCamelException; import org.apache.camel.dsl.jbang.core.common.RuntimeType; import org.apache.camel.dsl.jbang.core.common.RuntimeUtil; import org.apache.camel.dsl.jbang.core.common.SourceScheme; @@ -58,7 +57,12 @@ public class Export extends ExportBaseCommand { } if (gav == null) { - gav = "org.example.project:%s:%s".formatted(getProjectName(), getVersion()); + String pn = getProjectName(); + if (pn == null) { + System.err.println("Failed to resolve project name: Please provide --name, --gav or source file"); + return 1; + } + gav = "org.example.project:%s:%s".formatted(pn, getVersion()); } switch (runtime) { @@ -161,7 +165,6 @@ public class Export extends ExportBaseCommand { } protected String getProjectName() { - if (name != null) { return name; } @@ -177,8 +180,7 @@ public class Export extends ExportBaseCommand { return FileUtil.onlyName(SourceScheme.onlyName(files.get(0))); } - throw new RuntimeCamelException( - "Failed to resolve project name - please provide --name, --gav or source file"); + return null; } protected String getVersion() {
