jamesnetherton commented on code in PR #7082:
URL: https://github.com/apache/camel-quarkus/pull/7082#discussion_r1979432868
##########
integration-test-groups/azure/azure-servicebus/src/test/java/org/apache/camel/quarkus/component/azure/servicebus/it/AzureServiceBusTest.java:
##########
@@ -357,7 +366,10 @@ static Stream<Arguments> produceConsumeOptions() {
String[] payloadTypes = { String.class.getSimpleName(),
byte[].class.getSimpleName(),
BinaryData.class.getSimpleName() };
- AmqpTransportType[] transportTypes = AmqpTransportType.values();
+ //in mocked backend, the AMQP_WEB_SOCKET is not supported, see
https://github.com/Azure/azure-service-bus-emulator-installer/issues/51
+ AmqpTransportType[] transportTypes =
Arrays.stream(AmqpTransportType.values())
+ .filter(type -> AzureServiceBusHelper.isMockBackEnd() && type
!= AmqpTransportType.AMQP_WEB_SOCKETS)
+ .toArray(AmqpTransportType[]::new);
Review Comment:
When testing against the real Azure service this results in an empty array.
Maybe simplify to:
```suggestion
AmqpTransportType[] transportTypes;
if (AzureServiceBusHelper.isMockBackEnd()) {
transportTypes = new AmqpTransportType[] {
AmqpTransportType.AMQP };
} else {
transportTypes = AmqpTransportType.values();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
