squakez commented on code in PR #17418:
URL: https://github.com/apache/camel/pull/17418#discussion_r1989395975
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/src/main/java/org/apache/camel/dsl/jbang/core/commands/kubernetes/KubernetesExport.java:
##########
@@ -331,6 +331,8 @@ public Integer export() throws Exception {
var jkubeVersion = jkubeMavenPluginVersion(settings,
mapBuildProperties());
buildProperties.add("jkube.version=%s".formatted(jkubeVersion));
+ setContainerHealthPaths();
Review Comment:
Why do you need to do this? It defeats the purpose of the component. Ideally
you need to include those probes on the Deployment without worrying which is
the runtime used.
##########
docs/user-manual/modules/ROOT/pages/camel-jbang-kubernetes.adoc:
##########
@@ -180,6 +180,31 @@ The Kubernetes plugin export command also inherits all
options from the arbitrar
TIP: See the possible options by running: `camel kubernetes export --help` for
more details.
+=== Kubernetes Container Health Probes
+
+The
https://camel.apache.org/components/next/others/observability-services.html[Observability
Services] component is set by default in the project created by the export
command, then the health path probes are prefixed with the `/observe` endpoint,
regardless if they are Quarkus or Spring Boot.
Review Comment:
The link may fail in `camel-website`. Add the link to the component instead.
##########
docs/user-manual/modules/ROOT/pages/camel-jbang-kubernetes.adoc:
##########
@@ -180,6 +180,31 @@ The Kubernetes plugin export command also inherits all
options from the arbitrar
TIP: See the possible options by running: `camel kubernetes export --help` for
more details.
+=== Kubernetes Container Health Probes
+
+The
https://camel.apache.org/components/next/others/observability-services.html[Observability
Services] component is set by default in the project created by the export
command, then the health path probes are prefixed with the `/observe` endpoint,
regardless if they are Quarkus or Spring Boot.
+
+These are the HTTP Container probe endpoints.
+
+For Quarkus.
+[source]
+----
+/observe/health/live
+/observe/health/ready
+/observe/health/started
+----
+
+For Spring Boot (there is no startup probe)
+[source]
+----
+/observe/health/liveness
Review Comment:
These should be the same of the ones we have for the other runtimes. It is
possible that the springboot also exposes those as an alias, but we should make
use of the harmonized ones.
##########
docs/user-manual/modules/ROOT/pages/camel-jbang-kubernetes.adoc:
##########
@@ -180,6 +180,31 @@ The Kubernetes plugin export command also inherits all
options from the arbitrar
TIP: See the possible options by running: `camel kubernetes export --help` for
more details.
+=== Kubernetes Container Health Probes
+
+The
https://camel.apache.org/components/next/others/observability-services.html[Observability
Services] component is set by default in the project created by the export
command, then the health path probes are prefixed with the `/observe` endpoint,
regardless if they are Quarkus or Spring Boot.
Review Comment:
Also, camel-main runtime would be the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
