essobedo commented on code in PR #634:
URL: https://github.com/apache/camel-karaf/pull/634#discussion_r2174341405
##########
components/camel-cxf/camel-cxf-all/pom.xml:
##########
@@ -65,7 +65,7 @@
jakarta.xml.ws*;version="${camel-osgi-jakarta-xml-ws-version}",
jakarta.xml.bind*;version="${camel-osgi-jakarta-bind-version}",
jakarta.validation*;resolution:=optional;version="${camel-osgi-jakarta-validation-version}",
- jakarta.jws*;version="${camel-osgi-jakarta-jws-version}",
+ jakarta.jws*;version="${camel-osgi-jakarta-xml-ws-version}",
Review Comment:
I can see that in version 4, they merged those APIs, so maybe we could
remove `camel-osgi-jakarta-jws-version` from the parent pom
(https://github.com/apache/camel-karaf/blob/main/pom.xml#L532) as it should not
be used anymore. WDY?
##########
features/src/main/feature/camel-features.xml:
##########
@@ -950,6 +949,11 @@
<bundle>mvn:org.apache.camel.karaf/camel-cxf-blueprint/${project.version}</bundle>
<bundle>mvn:org.apache.camel.karaf/camel-cxf-transport-blueprint/${project.version}</bundle>
</feature>
+ <feature name='camel-cxf-jetty' version='${project.version}'
start-level='50'>
+ <feature version='${camel-osgi-version-range}'>camel-jetty</feature>
Review Comment:
Should not depend on camel-jetty but rather on jetty directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
