apupier commented on code in PR #18682:
URL: https://github.com/apache/camel/pull/18682#discussion_r2222450618
##########
core/camel-support/src/main/java/org/apache/camel/support/ObjectHelper.java:
##########
@@ -478,7 +478,7 @@ public static Object invokeMethod(Method method, Object
instance, Object... para
public static Object invokeMethodSafe(Method method, Object instance,
Object... parameters)
throws InvocationTargetException, IllegalAccessException {
Object answer;
- if (!method.isAccessible()) {
+ if (!method.canAccess(instance)) {
Review Comment:
```
[[1;31mERROR[m]
org.apache.camel.processor.RoutingSlipOnExceptionTest.testException -- Time
elapsed: 0.131 s <<< ERROR!
org.apache.camel.CamelExecutionException: Exception occurred during
execution on the exchange: Exchange[ED4E1D0B2DAC4F1-0000000000000000]
at
org.apache.camel.CamelExecutionException.wrapCamelExecutionException(CamelExecutionException.java:45)
at
org.apache.camel.support.ExchangeHelper.extractResultBody(ExchangeHelper.java:701)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:594)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.extractResultBody(DefaultProducerTemplate.java:590)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.sendBody(DefaultProducerTemplate.java:188)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.sendBody(DefaultProducerTemplate.java:194)
at
org.apache.camel.processor.DynamicRouterOnExceptionTest.testException(DynamicRouterOnExceptionTest.java:59)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
at
java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)
Caused by: org.apache.camel.RuntimeExchangeException:
IllegalArgumentException occurred invoking method: public static
java.lang.String
org.apache.camel.processor.DynamicRouterOnExceptionTest.whereTo(org.apache.camel.Exchange)
using arguments: [Exchange[ED4E1D0B2DAC4F1-0000000000000000]] on the exchange:
Exchange[ED4E1D0B2DAC4F1-0000000000000000]
at
org.apache.camel.component.bean.MethodInfo.invoke(MethodInfo.java:513)
at
org.apache.camel.component.bean.MethodInfo$1.doProceed(MethodInfo.java:309)
at
org.apache.camel.component.bean.MethodInfo$1.proceed(MethodInfo.java:286)
at
org.apache.camel.component.bean.AbstractBeanProcessor.useMethodInvocation(AbstractBeanProcessor.java:123)
at
org.apache.camel.component.bean.AbstractBeanProcessor.process(AbstractBeanProcessor.java:89)
at
org.apache.camel.impl.engine.DefaultAsyncProcessorAwaitManager.process(DefaultAsyncProcessorAwaitManager.java:82)
at
org.apache.camel.support.AsyncProcessorSupport.process(AsyncProcessorSupport.java:32)
at
org.apache.camel.language.bean.BeanExpression.invokeBean(BeanExpression.java:369)
at
org.apache.camel.language.bean.BeanExpression.evaluate(BeanExpression.java:222)
at
org.apache.camel.language.bean.BeanExpression.evaluate(BeanExpression.java:233)
at
org.apache.camel.processor.RoutingSlip.createRoutingSlipIterator(RoutingSlip.java:207)
at
org.apache.camel.processor.RoutingSlip.doRoutingSlipWithExpression(RoutingSlip.java:231)
at org.apache.camel.processor.RoutingSlip.process(RoutingSlip.java:195)
at
org.apache.camel.processor.errorhandler.RedeliveryErrorHandler$RedeliveryTask.redeliver(RedeliveryErrorHandler.java:895)
at
org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.doRun(DefaultReactiveExecutor.java:199)
at
org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.executeReactiveWork(DefaultReactiveExecutor.java:189)
at
org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.tryExecuteReactiveWork(DefaultReactiveExecutor.java:166)
at
org.apache.camel.impl.engine.DefaultReactiveExecutor$Worker.schedule(DefaultReactiveExecutor.java:148)
at
org.apache.camel.impl.engine.DefaultReactiveExecutor.scheduleMain(DefaultReactiveExecutor.java:59)
at org.apache.camel.processor.Pipeline.process(Pipeline.java:163)
at
org.apache.camel.impl.engine.CamelInternalProcessor.processNonTransacted(CamelInternalProcessor.java:347)
at
org.apache.camel.impl.engine.CamelInternalProcessor.process(CamelInternalProcessor.java:323)
at
org.apache.camel.component.direct.DirectProducer.process(DirectProducer.java:102)
at
org.apache.camel.impl.engine.SharedCamelInternalProcessor.processNonTransacted(SharedCamelInternalProcessor.java:156)
at
org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:133)
at
org.apache.camel.impl.engine.SharedCamelInternalProcessor$1.process(SharedCamelInternalProcessor.java:89)
at
org.apache.camel.impl.engine.DefaultAsyncProcessorAwaitManager.process(DefaultAsyncProcessorAwaitManager.java:82)
at
org.apache.camel.impl.engine.SharedCamelInternalProcessor.process(SharedCamelInternalProcessor.java:86)
at
org.apache.camel.support.cache.DefaultProducerCache.send(DefaultProducerCache.java:178)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:175)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:171)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.send(DefaultProducerTemplate.java:152)
at
org.apache.camel.impl.engine.DefaultProducerTemplate.sendBody(DefaultProducerTemplate.java:186)
... 8 more
Caused by: java.lang.IllegalArgumentException: non-null object for public
static java.lang.String
org.apache.camel.processor.DynamicRouterOnExceptionTest.whereTo(org.apache.camel.Exchange)
at
java.base/java.lang.reflect.AccessibleObject.canAccess(AccessibleObject.java:454)
at
org.apache.camel.support.ObjectHelper.invokeMethodSafe(ObjectHelper.java:481)
at
org.apache.camel.component.bean.MethodInfo.invoke(MethodInfo.java:506)
... 40 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]