apupier commented on code in PR #18703:
URL: https://github.com/apache/camel/pull/18703#discussion_r2227558911
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/Export.java:
##########
@@ -327,7 +327,8 @@ protected void copyDockerFiles(String buildDir) throws
Exception {
Path docker = Path.of(buildDir).resolve("src/main/docker");
Files.createDirectories(docker);
String[] ids = gav.split(":");
- InputStream is =
ExportCamelMain.class.getClassLoader().getResourceAsStream("templates/Dockerfile.tmpl");
+ InputStream is
+ =
ExportCamelMain.class.getClassLoader().getResourceAsStream("templates/Dockerfile"
+ javaVersion + ".tmpl");
Review Comment:
Shouldn't we fallback to the closest (or at least the latest) Dockerfile in
case the user is specifying another java-version than 17 and 21, like 24 or 25?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
