squakez commented on code in PR #19963:
URL: https://github.com/apache/camel/pull/19963#discussion_r2538454660
##########
components/camel-soap/src/main/java/org/apache/camel/dataformat/soap/SoapConstants.java:
##########
@@ -19,6 +19,7 @@
public final class SoapConstants {
public static String SOAP_METHOD_NAME = "CamelSoapMethodName";
+ public static String SOAP_ACTION = "CamelSoapAction";
Review Comment:
This is for internal use only in order to support the component. The user
should changes nothing.
##########
core/camel-xml-jaxp/src/main/java/org/apache/camel/converter/jaxp/XmlConverter.java:
##########
@@ -481,22 +481,10 @@ public SAXSource toSAXSourceFromStream(StreamSource
source, Exchange exchange) t
XMLReader xmlReader = null;
try {
- // use the SAXPaserFactory which is set from exchange
Review Comment:
Nobody should use this in Camel 4 since a while as it was deprecated in 3.x.
We should be safe removing this piece of code. The original feature was
introduced in https://issues.apache.org/jira/browse/CAMEL-7721
##########
components/camel-ftp/src/test/java/org/apache/camel/component/file/remote/integration/FtpPollEnrichBridgeErrorHandlerIT.java:
##########
@@ -95,10 +95,6 @@ public Exchange aggregate(Exchange oldExchange, Exchange
newExchange) {
oldExchange.getIn().setBody(null);
oldExchange.setOut(null);
}
- // in case of exception we are bridged then we want to perform
- // redeliveries etc.
- // so we need to turn of exhausted redelivery
- oldExchange.removeProperties(Exchange.REDELIVERY_EXHAUSTED);
Review Comment:
Never used, the test passes locally.
##########
components/camel-cxf/camel-cxf-common/src/main/java/org/apache/camel/component/cxf/common/header/CxfHeaderHelper.java:
##########
@@ -50,7 +50,6 @@ public final class CxfHeaderHelper {
defineMapping(Exchange.CONTENT_TYPE, Message.CONTENT_TYPE);
defineMapping(Exchange.HTTP_CHARACTER_ENCODING, Message.ENCODING);
defineMapping(Exchange.HTTP_QUERY, Message.QUERY_STRING);
- defineMapping(Exchange.ACCEPT_CONTENT_TYPE,
Message.ACCEPT_CONTENT_TYPE);
Review Comment:
The ACCEPT_CONTENT_TYPE is never used internally. This method was a mapping,
and in theory the user should have been already moved to CXF message accept
content type instead.
##########
components/camel-undertow/src/main/java/org/apache/camel/component/undertow/ExchangeHeaders.java:
##########
@@ -25,6 +25,9 @@ public final class ExchangeHeaders {
public static final HttpString AUTHENTICATION = new
HttpString("CamelAuthentication");
public static final HttpString AUTHENTICATION_FAILURE_POLICY_ID = new
HttpString("CamelAuthenticationFailurePolicyId");
+ @Deprecated(since = "4.17.0")
Review Comment:
We could have removed as it's not in use. However, let's follow the
deprecation policy and mark it now for future removal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
