(camel) branch main updated: fix(components): file stream closure

[pcongiusti]

This is an automated email from the ASF dual-hosted git repository.

pcongiusti pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new 1a7af7bb6fe7 fix(components): file stream closure
1a7af7bb6fe7 is described below

commit 1a7af7bb6fe737b5a3b92b770bb72fa71ba6318e
Author: Pasquale Congiusti <pasquale.congiu...@gmail.com>
AuthorDate: Thu Nov 27 10:36:39 2025 +0100

    fix(components): file stream closure
---
 .../java/org/apache/camel/component/file/FileOperations.java     | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git 
a/components/camel-file/src/main/java/org/apache/camel/component/file/FileOperations.java
 
b/components/camel-file/src/main/java/org/apache/camel/component/file/FileOperations.java
index e3a03345dd66..eebb32ee50b0 100644
--- 
a/components/camel-file/src/main/java/org/apache/camel/component/file/FileOperations.java
+++ 
b/components/camel-file/src/main/java/org/apache/camel/component/file/FileOperations.java
@@ -478,7 +478,8 @@ public class FileOperations implements 
GenericFileOperations<File> {
         FileChannel channel
                 = exchange.getProperty(asExclusiveReadLockKey(path, 
Exchange.FILE_LOCK_CHANNEL_FILE), FileChannel.class);
         if (channel != null) {
-            try (FileChannel out = new FileOutputStream(target).getChannel()) {
+            try (FileOutputStream fos = new FileOutputStream(target);
+                 FileChannel out = fos.getChannel()) {
                 LOG.trace("writeFileByFile using FileChannel: {} -> {}", 
source, target);
                 channel.transferTo(0, channel.size(), out);
             }
@@ -559,11 +560,15 @@ public class FileOperations implements 
GenericFileOperations<File> {
     /**
      * Creates and prepares the output file channel. Will position itself in 
correct position if the file is writable
      * eg. it should append or override any existing content.
+     *
+     * NOTE: the client of this factory method is in charge to close the 
resource.
      */
     private SeekableByteChannel prepareOutputFileChannel(File target) throws 
IOException {
         if (endpoint.getFileExist() == GenericFileExist.Append) {
+            // NOTE: we open the channel and seek the position at the end of 
the channel. As we return
+            // this stream, we must not close it (letting the client doing so).
             SeekableByteChannel out
-                    = Files.newByteChannel(target.toPath(), 
StandardOpenOption.CREATE, StandardOpenOption.APPEND);
+                    = Files.newByteChannel(target.toPath(), 
StandardOpenOption.CREATE, StandardOpenOption.APPEND); // NOSONAR
             return out.position(out.size());
         }
         return Files.newByteChannel(target.toPath(), StandardOpenOption.WRITE, 
StandardOpenOption.TRUNCATE_EXISTING,