mcarlett commented on code in PR #21362:
URL: https://github.com/apache/camel/pull/21362#discussion_r2797934310
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/support/JBangTestSupport.java:
##########
@@ -178,13 +182,13 @@ protected void checkCommandOutputs(String command, String
contains, int waitForS
protected void checkCommandOutputs(String command, String contains) {
Assertions.assertThat(execute(command))
- .as("command camel " + command + " should output " + contains)
+ .as("command " + MAIN_COMMAND + " " + command + "should
output " + contains)
Review Comment:
does it compile? I cannot find the `MAIN_COMMAND` variable, you should use
now `getMainCommand()`, am I wrong?
##########
dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/support/JBangTestSupport.java:
##########
@@ -138,7 +138,11 @@ protected String execute(final String command) {
}
protected String executeBackground(final String command) {
- return containerService.executeBackground(command);
+ return containerService.execute(command + " --background");
Review Comment:
I'm expecting this to be restored on the current version
`containerService.executeBackground(command)` or there are specific reasons?
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
