gansheer commented on code in PR #22134:
URL: https://github.com/apache/camel/pull/22134#discussion_r2964550650
##########
tests/camel-itest/src/test/java/org/apache/camel/itest/sql/FromJmsToJdbcIdempotentConsumerToJmsTest.java:
##########
@@ -201,38 +213,44 @@ public void process(Exchange exchange) throws Exception {
NotifyBuilder notify
= new
NotifyBuilder(context).whenExactlyDone(4).whenDoneSatisfied(mockA).whenDoneSatisfied(mockB).create();
- template.sendBodyAndHeader("activemq2:queue:inbox", "D", "uid", 111);
- template.sendBodyAndHeader("activemq2:queue:inbox", "E", "uid", 222);
- template.sendBodyAndHeader("activemq2:queue:inbox", "F", "uid", 333);
+ template.sendBodyAndHeader(inboxQueue(), "D", "uid", 111);
+ template.sendBodyAndHeader(inboxQueue(), "E", "uid", 222);
+ template.sendBodyAndHeader(inboxQueue(), "F", "uid", 333);
assertTrue(notify.matchesWaitTime(), "Should complete 4 messages");
// check that there is three messages in the database and JMS queue
assertEquals(3, jdbcTemplate.queryForObject("select count(*) from
CAMEL_MESSAGEPROCESSED", int.class));
- assertEquals("DONE-D", consumer.receiveBody("activemq2:queue:outbox",
3000));
- assertEquals("DONE-E", consumer.receiveBody("activemq2:queue:outbox",
3000));
- assertEquals("DONE-F", consumer.receiveBody("activemq2:queue:outbox",
3000));
+ assertEquals("DONE-D", consumer.receiveBody(outboxQueue(), 3000));
+ assertEquals("DONE-E", consumer.receiveBody(outboxQueue(), 3000));
+ assertEquals("DONE-F", consumer.receiveBody(outboxQueue(), 3000));
}
protected void checkInitialState() {
// check there are no messages in the database and JMS queue
assertEquals(0, jdbcTemplate.queryForObject("select count(*) from
CAMEL_MESSAGEPROCESSED", int.class));
- assertNull(consumer.receiveBody("activemq2:queue:outbox", 100));
+ // drain any stale messages from outbox and DLQ to ensure clean state
+ while (consumer.receiveBody(outboxQueue(), 100) != null) {
Review Comment:
Could Awaitility.await() be used here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
