aldettinger commented on code in PR #8450: URL: https://github.com/apache/camel-quarkus/pull/8450#discussion_r2966918902
########## integration-test-groups/aws2/aws2-sqs/src/main/java/org/apache/camel/quarkus/component/aws2/sqs/it/BatchConsumerMessageCollector.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.quarkus.component.aws2.sqs.it; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; + +import jakarta.enterprise.context.ApplicationScoped; + +@ApplicationScoped +public class BatchConsumerMessageCollector { + + private final List<String> messages = Collections.synchronizedList(new ArrayList<>()); + + public void collect(String message) { + messages.add(message); + } + + public List<String> getMessages() { + return new ArrayList<>(messages); Review Comment: Does `ArrayList` constructor iterate over the `messages` list ? If yes, don't we have a thread safety issue as `synchronizedList` does not protect iteration ? Note that race conditions could be uneasy to demonstrate and probability might be very low. Also, our community have already used `CopyOnWriteArrayList` as a safe no brainer in the past given the number of test messages is quite low. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
