smongiar commented on PR #22196:
URL: https://github.com/apache/camel/pull/22196#issuecomment-4112354677

   > _Claude Code on behalf of Guillaume Nodet_
   > 
   > Thanks for the fix! One suggestion: the `--java-version` option in 
`Run.java` is missing the `completionCandidates` attribute that 
`ExportBaseCommand` already uses. Could you align it so tab completion works 
for `camel run` as well?
   > 
   > ```java
   > @CommandLine.Option(names = { "--java-version" }, completionCandidates = 
JavaVersionCompletionCandidates.class,
   >                     description = "Java version 
(${COMPLETION-CANDIDATES})", defaultValue = "21")
   > ```
   > 
   > We can provide the change if needed.
   
   Done, thank you for the review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to