apupier commented on code in PR #22247:
URL: https://github.com/apache/camel/pull/22247#discussion_r2986345368
##########
.github/workflows/pr-build-main.yml:
##########
@@ -92,61 +98,30 @@ jobs:
- name: mvn test
uses: ./.github/actions/incremental-build
with:
- mode: test
pr-id: ${{ github.event.number || inputs.pr_number }}
github-token: ${{ secrets.GITHUB_TOKEN }}
skip-mvnd-install: 'true'
artifact-upload-suffix: java-${{ matrix.java }}
- - name: Post CI test summary comment
- if: always() && !matrix.experimental
- uses: actions/github-script@v8
- with:
- script: |
- const fs = require('fs');
- const commentFile = 'incremental-test-comment.md';
- if (!fs.existsSync(commentFile)) return;
- const body = fs.readFileSync(commentFile, 'utf8').trim();
- if (!body) return;
-
- const prNumber = ${{ github.event.number || inputs.pr_number || 0
}};
- if (!prNumber) {
- core.warning('Could not determine PR number, skipping test
summary comment');
- return;
- }
-
- const marker = '<!-- ci-tested-modules -->';
-
- try {
- const { data: comments } = await
github.rest.issues.listComments({
- owner: context.repo.owner,
- repo: context.repo.repo,
- issue_number: prNumber,
- });
- const existing = comments.find(c => c.body &&
c.body.includes(marker));
-
- if (existing) {
- await github.rest.issues.updateComment({
- owner: context.repo.owner,
- repo: context.repo.repo,
- comment_id: existing.id,
- body: body,
- });
- } else {
- await github.rest.issues.createComment({
- owner: context.repo.owner,
- repo: context.repo.repo,
- issue_number: prNumber,
- body: body,
- });
- }
- } catch (error) {
- core.warning(`Failed to post CI test summary comment:
${error.message}`);
- }
- - name: mvn test parent pom dependencies changed
- if: always() && !matrix.experimental
- uses: ./.github/actions/detect-dependencies
+ extra-modules: ${{ inputs.extra_modules || '' }}
+ - name: Save PR number and test comment for commenter workflow
+ if: always() && matrix.java == '21'
Review Comment:
Why is it filtering only on JDK 21?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
