This is an automated email from the ASF dual-hosted git repository. fmariani pushed a commit to branch camel-4.18.x in repository https://gitbox.apache.org/repos/asf/camel.git
commit e12eaf84273980477e858e19526ff5f235e97c2f Author: Croway <[email protected]> AuthorDate: Thu Apr 2 11:30:16 2026 +0200 ci: remove redundant getPID() calls in JBang IT tests executeBackground() already returns the parsed PID directly. Calling getPID(process) tries to re-parse the PID string by splitting on "PID:" which doesn't exist in the already-parsed value, causing ArrayIndexOutOfBoundsException. Aligns with main branch (5cf8b1c632a) which uses process directly. --- .../java/org/apache/camel/dsl/jbang/it/CmdStartStopITCase.java | 8 ++++---- .../test/java/org/apache/camel/dsl/jbang/it/JolokiaITCase.java | 2 +- .../test/java/org/apache/camel/dsl/jbang/it/RunCommandITCase.java | 2 +- .../org/apache/camel/dsl/jbang/it/RunCommandOnMqttITCase.java | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/CmdStartStopITCase.java b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/CmdStartStopITCase.java index f99a8c8da832..7001a2b412c5 100644 --- a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/CmdStartStopITCase.java +++ b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/CmdStartStopITCase.java @@ -43,7 +43,7 @@ public class CmdStartStopITCase extends JBangTestSupport { String process = executeBackground(String.format("run %s/FromDirectoryRoute.java", mountPoint())); executeBackground(String.format("run %s/route2.yaml", mountPoint())); checkLogContains("Hello world!"); - execute("cmd stop-route " + getPID(process)); + execute("cmd stop-route " + process); checkCommandOutputsPattern("get route", "route1\\s+timer:\\/\\/(yaml|java)\\?period=1000\\s+Stopped.*\\n.*route2.*timer:\\/\\/(yaml|java)\\?period=1000\\s+Started", ASSERTION_WAIT_SECONDS); @@ -82,7 +82,7 @@ public class CmdStartStopITCase extends JBangTestSupport { executeBackground(String.format("run %s/route2.yaml", mountPoint())); checkLogContains("Hello world!"); execute("cmd stop-route"); - execute("cmd start-route " + getPID(process)); + execute("cmd start-route " + process); checkCommandOutputsPattern("get route", "route1\\s+timer:\\/\\/(yaml|java)\\?period=1000\\s+Started.*\\n.*route2.*timer:\\/\\/(yaml|java)\\?period=1000\\s+Stopped", ASSERTION_WAIT_SECONDS); @@ -111,7 +111,7 @@ public class CmdStartStopITCase extends JBangTestSupport { execInContainer(String.format("chmod +x %s/watch-sleep", mountPoint())); Assertions.assertThat( execInContainer(String.format("%s/watch-sleep", mountPoint()))) - .as("watch command should output PID" + getPID(process)) - .contains(getPID(process)); + .as("watch command should output PID" + process) + .contains(process); } } diff --git a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/JolokiaITCase.java b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/JolokiaITCase.java index b6281a00f363..bfd59c993daf 100644 --- a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/JolokiaITCase.java +++ b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/JolokiaITCase.java @@ -37,7 +37,7 @@ public class JolokiaITCase extends JBangTestSupport { .contains("\"agentContext\":\"/jolokia\""); Assertions.assertThat(execute("jolokia FromDirectoryRoute --stop")) .as("Jolokia should stop") - .contains("Stopped Jolokia for PID " + getPID(process)); + .contains("Stopped Jolokia for PID " + process); } @Test diff --git a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandITCase.java b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandITCase.java index 86bbe5ebef5d..3136b97e5092 100644 --- a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandITCase.java +++ b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandITCase.java @@ -156,7 +156,7 @@ public class RunCommandITCase extends JBangTestSupport { final String process = executeBackground(String.format("run %s/cheese.xml --camel-version=%s", mountPoint(), version)); checkLogContainsPattern(String.format(" Apache Camel %s .* started", version)); checkLogContains(DEFAULT_MSG); - execute("stop " + getPID(process)); + execute("stop " + process); } @Test diff --git a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandOnMqttITCase.java b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandOnMqttITCase.java index 7e3ac64f26bc..254d09d616f1 100644 --- a/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandOnMqttITCase.java +++ b/dsl/camel-jbang/camel-jbang-it/src/test/java/org/apache/camel/dsl/jbang/it/RunCommandOnMqttITCase.java @@ -54,7 +54,7 @@ public class RunCommandOnMqttITCase extends JBangTestSupport { checkLogContains("Started route1 (kamelet:mqtt5-source)"); final String payloadFile = "payload.json"; newFileInDataFolder(payloadFile, "{\"value\": 21}"); - sendCmd(String.format("%s/%s", mountPoint(), payloadFile), getPID(process)); + sendCmd(String.format("%s/%s", mountPoint(), payloadFile), process); checkLogContains("The temperature is 21"); } @@ -63,7 +63,7 @@ public class RunCommandOnMqttITCase extends JBangTestSupport { copyResourceInDataFolder(TestResources.STUB_ROUTE); final String process = executeBackground(String.format("run %s/%s --stub=jms", mountPoint(), TestResources.STUB_ROUTE.getName())); - checkCommandOutputs("cmd send --body='Hello camel from stubbed jms' " + getPID(process), "Sent (success)"); + checkCommandOutputs("cmd send --body='Hello camel from stubbed jms' " + process, "Sent (success)"); checkCommandOutputs("cmd stub --browse", "Hello camel from stubbed jms", ASSERTION_WAIT_SECONDS); }
