gnodet commented on PR #22247: URL: https://github.com/apache/camel/pull/22247#issuecomment-4185211494
_Claude Code on behalf of Guillaume Nodet_ ### Fork testing results (round 4 — all green ✅) Tested the full CI pipeline on the [gnodet/camel](https://github.com/gnodet/camel) fork with two separate PRs, each exercising a different detection path. --- #### PR #1: File-path detection — [gnodet/camel#13](https://github.com/gnodet/camel/pull/13) **Change:** Added a comment to `components/camel-bean/src/test/java/.../BeanInfoTest.java` **Expected:** CI detects `components/camel-bean` as affected module **Run:** [Build and test #23959189857](https://github.com/gnodet/camel/actions/runs/23959189857) — ✅ all 3 JDK jobs passed CI comment posted on the PR: > 🧪 **CI tested the following changed modules:** > > - `components/camel-bean` > > > ℹ️ Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents. --- #### PR #2: POM dependency detection — [gnodet/camel#14](https://github.com/gnodet/camel/pull/14) **Change:** Changed `commons-lang3-version` from 3.20.0 to 3.19.0 in `parent/pom.xml` **Expected:** CI detects property change, finds modules referencing `${commons-lang3-version}` **Run:** [Build and test #23959192108](https://github.com/gnodet/camel/actions/runs/23959192108) — ✅ all 3 JDK jobs passed CI comment posted on the PR: > 🧪 **CI tested the following changed modules:** > > - `parent` > > ✅ **POM dependency changes: targeted tests included** > > Changed properties: commons-lang3-version > > Modules affected by dependency changes (2): > - `:camel-report-maven-plugin` > - `:camel-cxf-soap` > > All tested modules (3 modules): > - Camel :: CXF :: SOAP > - Camel :: Catalog :: Camel Report Maven Plugin > - Camel :: Parent --- #### Bugs found and fixed during testing 1. **Empty associative array under `set -u`** — `checkManualItTests()` crashed with `it_sources: unbound variable` when no modules matched `manual-it-mapping.txt`. Fixed by using a counter variable `it_found` instead of `${#it_sources[@]}`. 2. **Duplicate modules in CI comment** — Maven reactor output includes both `Camel :: Foo` and `Camel :: Foo [jar]` lines. The grep/sed pipeline wasn't stripping the `[packaging]` suffix before deduplication. Fixed by adding `sed 's/ *\[.*\]$//'`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
