gnodet opened a new pull request, #22478:
URL: https://github.com/apache/camel/pull/22478

   [CAMEL-23274](https://issues.apache.org/jira/browse/CAMEL-23274)
   
   Fix two critical SonarCloud bugs reported on the `main` branch:
   
   1. **ModelParserTest.java** (S5783): Extract `ModelParser` construction out 
of the `assertThrows` lambda so that only `parseRoutesDefinition()` is the 
throwing call. Previously both the constructor and the method could throw the 
same checked exception, making it ambiguous which call caused the exception.
   
   2. **EnvironmentHelperTest.java** (S5845): Replace `assertNotNull(result)` 
with `assertDoesNotThrow(...)` for three tests where `result` is a primitive 
`boolean`. Comparing a primitive with `null` via `assertNotNull` is always true 
due to autoboxing and does not test anything meaningful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to