(camel) branch main updated: CAMEL-23274: Fix SonarCloud critical bugs in test code (#22478)

[gnodet]

This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/main by this push:
     new d0019eaf4f3e CAMEL-23274: Fix SonarCloud critical bugs in test code 
(#22478)
d0019eaf4f3e is described below

commit d0019eaf4f3e2acd7d2b34125b30b5f4223d6fae
Author: Guillaume Nodet <gno...@gmail.com>
AuthorDate: Wed Apr 8 08:43:28 2026 +0200

    CAMEL-23274: Fix SonarCloud critical bugs in test code (#22478)
    
    Co-authored-by: Claude Opus 4.6 <nore...@anthropic.com>
---
 .../test/java/org/apache/camel/xml/in/ModelParserTest.java    |  3 ++-
 .../camel/dsl/jbang/core/common/EnvironmentHelperTest.java    | 11 ++++-------
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git 
a/core/camel-xml-io/src/test/java/org/apache/camel/xml/in/ModelParserTest.java 
b/core/camel-xml-io/src/test/java/org/apache/camel/xml/in/ModelParserTest.java
index 882ec709678b..7f6ac36a195c 100644
--- 
a/core/camel-xml-io/src/test/java/org/apache/camel/xml/in/ModelParserTest.java
+++ 
b/core/camel-xml-io/src/test/java/org/apache/camel/xml/in/ModelParserTest.java
@@ -469,8 +469,9 @@ public class ModelParserTest {
                   </route>
                 </routes>
                 """;
+        ModelParser parser = new ModelParser(new StringReader(routesXml));
         Exception e = assertThrows(Exception.class, () -> {
-            new ModelParser(new 
StringReader(routesXml)).parseRoutesDefinition();
+            parser.parseRoutesDefinition();
         });
         assertThat(e).hasStackTraceContaining("already has a predicate");
     }
diff --git 
a/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/common/EnvironmentHelperTest.java
 
b/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/common/EnvironmentHelperTest.java
index 0a5985a4ac1c..e4ca3124e6f6 100644
--- 
a/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/common/EnvironmentHelperTest.java
+++ 
b/dsl/camel-jbang/camel-jbang-core/src/test/java/org/apache/camel/dsl/jbang/core/common/EnvironmentHelperTest.java
@@ -18,8 +18,8 @@ package org.apache.camel.dsl.jbang.core.common;
 
 import org.junit.jupiter.api.Test;
 
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertFalse;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 class EnvironmentHelperTest {
@@ -28,20 +28,17 @@ class EnvironmentHelperTest {
     void testIsColorEnabledReturnsBoolean() {
         // Should not throw and should return a boolean value
         // The actual result depends on the environment, but the method should 
work
-        boolean result = EnvironmentHelper.isColorEnabled();
-        assertNotNull(result);
+        assertDoesNotThrow(() -> EnvironmentHelper.isColorEnabled());
     }
 
     @Test
     void testIsCIEnvironmentReturnsBoolean() {
-        boolean result = EnvironmentHelper.isCIEnvironment();
-        assertNotNull(result);
+        assertDoesNotThrow(() -> EnvironmentHelper.isCIEnvironment());
     }
 
     @Test
     void testIsInteractiveTerminalReturnsBoolean() {
-        boolean result = EnvironmentHelper.isInteractiveTerminal();
-        assertNotNull(result);
+        assertDoesNotThrow(() -> EnvironmentHelper.isInteractiveTerminal());
     }
 
     @Test