gnodet opened a new pull request, #22525: URL: https://github.com/apache/camel/pull/22525
## Summary - Fix a bug in `incremental-build.sh` where modules in the `EXCLUSION_LIST` that are also the primary changed modules get excluded from the Maven reactor, causing the build to fail immediately - Add `filterExclusions()` function that removes exclusion entries conflicting with explicitly included `-pl` modules before passing the argument to Maven - Affects PRs that change modules like `camel-yaml-dsl`, `camel-yaml-dsl-maven-plugin`, or `docs` — these are in the exclusion list (to prevent them being pulled in as dependents via `-amd`) but must not be excluded when they are the primary changed modules **Root cause:** When Maven resolves `-pl dsl/camel-yaml-dsl/camel-yaml-dsl`, it maps the path to artifact ID `camel-yaml-dsl`. The exclusion `!:camel-yaml-dsl` then removes it from the reactor. The module is both included and excluded, so `mvnd` fails with exit code 1 in ~10 seconds with no Maven output. **Evidence:** PR #22059 triggers this — CI logs show "Testing affected modules and their dependents (17 modules)" then fails 10 seconds later. Tests pass locally (17 tests, 0 failures). Failure is 100% reproducible on re-runs. ## Test plan - [x] Tested `filterExclusions()` function with the exact PR #22059 scenario (`dsl/camel-yaml-dsl/camel-yaml-dsl` vs `!:camel-yaml-dsl`) — conflict correctly removed - [x] Tested with `:artifact-id` style includes — works correctly - [x] Tested with no conflicts — all exclusions preserved - [x] Tested edge case where all exclusions conflict — empty result handled by guard clause -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
