beskow opened a new pull request, #22677:
URL: https://github.com/apache/camel/pull/22677

   # Description
   
   This is a proposal for a potential enhancement for baggage management when 
using camel-opentelemetry2. The rationale and problem statement can be found in 
https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-23349. This seemed 
to me to be the most obvious and simplest solution, but there might of course 
be better ways?
   
   In essence, the pull request adds two public methods for setting and getting 
baggage entries from an OTEL span
   (encapsulated by OpenTelemetrySpanAdapter). The crucial detail is that the 
OpenTelemetrySpanAdapter encapsulates both the baggage and a baggageScope. 
Hence when adding a baggage entry, a new baggageScope is created which should 
replace the original baggageScope (which should be properly closed). 
   
   I also added a static Exchange context accessor for the 
OpenTelemetrySpanAdapter, which is not strictly necessary but may be convenient.
   
   # Target
   
   - [X] I checked that the commit is targeting the correct branch (Camel 4 
uses the `main` branch)
   
   # Tracking
   - [X] If this is a large change, bug fix, or code improvement, I checked 
there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for 
the change (usually before you start working on it).
   
   <!--
   # *Note*: trivial changes like, typos, minor documentation fixes and other 
small items do not require a JIRA issue. In this case your pull request should 
address just this issue, without pulling in other changes.
   -->
   
   # Apache Camel coding standards and style
   
   - [X] I checked that each commit in the pull request has a meaningful 
subject line and body.
   
   <!--
   If you're unsure, you can format the pull request title like `[CAMEL-XXX] 
Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the 
appropriate JIRA issue.
   -->
   
   - [X] I have run `mvn clean install -DskipTests` locally from root folder 
and I have committed all auto-generated changes.
   
   <!--
   You can run the aforementioned command in your module so that the build 
auto-formats your code. This will also be verified as part of the checks and 
your PR may be rejected if if there are uncommited changes after running `mvn 
clean install -DskipTests`.
   
   You can learn more about the contribution guidelines at 
https://github.com/apache/camel/blob/main/CONTRIBUTING.md
   -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to