Evynglais commented on PR #6582: URL: https://github.com/apache/camel-k/pull/6582#issuecomment-4294629325
Hi, "there is no reason to retry a build that is going to likely fail again for the same reason" This is not always true; the example that prompted me to work on this PR was for builds that were failing to due missing (temporarily) knative service endpoints. If the service isn't available during the build, then the operator will fail my integration; if it retried, then it would be successful once the service has started. Therefore, this change would exactly fix what I'm trying to fix -- not to say that there wouldn't be another (and perhaps, better) way of fixing this specific issue. Happy to take suggestions/pointers if you have any ideas. I do think that for retrying it would be good to be able to distinguish between different types of failure (actual "build" issues, vs "external dependency" issues), as I agree that there are build failures that can't be rectified, and we shouldn't necessarily waste resources retrying those. Regarding the deprecation of IP -- which I did notice -- could you point me to the "new" way of doing it, and I can update this PR to work off of that? I may have misunderstood, as I thought this would be a simple move to stick the same configuration in the `env.Platform`. Thanks for your comments, Evyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
