smongiar commented on code in PR #22835:
URL: https://github.com/apache/camel/pull/22835#discussion_r3161508616
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/process/Hawtio.java:
##########
@@ -116,14 +120,16 @@ protected Integer callHawtio() throws Exception {
Object hawt = clazz.getDeclaredConstructor().newInstance();
Method m = clazz.getMethod("setWar", String.class);
ObjectHelper.invokeMethod(m, hawt, war);
+ m = clazz.getMethod("setHost", String.class);
+ ObjectHelper.invokeMethod(m, hawt, host);
m = clazz.getMethod("setPort", Integer.class);
ObjectHelper.invokeMethod(m, hawt, port);
m = clazz.getMethod("run");
ObjectHelper.invokeMethod(m, hawt);
if (openUrl) {
// open web browser
- String url = "http://localhost:"; + port + "/hawtio";
+ String url = "http://"; + host + ":" + port + "/hawtio";
Review Comment:
It should be the default value, yet. It's at line
[46](https://github.com/apache/camel/pull/22835/changes#diff-58a14a72becb5f8554757084eb407003122e4d8539705f493f8739c07f6cec39R46).
Am I wrong? `127.0.0.1` is intentional to avoid IPv6 resolution issues on
s390x/ppc64le
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
