shaipan commented on code in PR #22840:
URL: https://github.com/apache/camel/pull/22840#discussion_r3167225617
##########
components/camel-salesforce/camel-salesforce-component/src/main/java/org/apache/camel/component/salesforce/internal/streaming/SubscriptionHelper.java:
##########
@@ -219,7 +225,9 @@ private void subscriptionFailed(StreamingApiConsumer
firstConsumer, Message mess
boolean abort = true;
LOG.warn(msg);
- if (isTemporaryError(message)) {
+ if (isTemporaryError(message) || error.equals(AUTHENTICATION_INVALID)
|| error.startsWith(DENIED_BY_SEC_POLICY)
+ || error.startsWith(AUTHORIZATION_ERROR) ||
error.equals(ORG_LIMIT_ERROR)
Review Comment:
> Nit: `AUTHORIZATION_ERROR` is `"403::"` and `ORG_LIMIT_ERROR` is
`"403::Organization total events daily limit exceeded"`. Since
`ORG_LIMIT_ERROR` starts with `"403::"`, the `startsWith(AUTHORIZATION_ERROR)`
check already covers it — the `equals(ORG_LIMIT_ERROR)` is redundant.
>
> (Note: `DENIED_BY_SEC_POLICY` uses a single colon
`"403:denied_by_security_policy"` so its separate `startsWith` check is
correctly needed.)
@gnodet Fixed this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
