davsclaus commented on code in PR #22932:
URL: https://github.com/apache/camel/pull/22932#discussion_r3186714093
##########
core/camel-core-model/src/main/java/org/apache/camel/model/ProcessorDefinitionHelper.java:
##########
@@ -264,13 +296,12 @@ private static <T> void
doFindType(List<ProcessorDefinition<?>> outputs, Class<T
}
// start from level 1
- doFindType(outputs, type, found, 1, maxDeep);
+ doFindTypeInNodes(outputs, type, found, 1, maxDeep);
}
- @SuppressWarnings({ "unchecked", "rawtypes" })
- private static <
- T> void doFindType(List<ProcessorDefinition<?>> outputs, Class<T>
type, List<T> found, int current, int maxDeep) {
- if (outputs == null || outputs.isEmpty()) {
+ private static <T> void doFindTypeInNodes(
Review Comment:
It looks like maxDeep is broken now. That it is no longer used as stop gap
to walk deeper.
This feature is used in advice with so there is likely some unit test that
checks this, and if not we should add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
