gnodet opened a new pull request, #23078: URL: https://github.com/apache/camel/pull/23078
[CAMEL-21438](https://issues.apache.org/jira/browse/CAMEL-21438) ## Summary - **Re-enable 12 FTPS integration tests** (camel-ftp) disabled since 2021 (CAMEL-16784). Migrated from SSLv3 (disabled in JDK 17+) to TLSv1.2. Restores FTPS test coverage that was completely absent for 4+ years. - **Re-enable 15 ProxyProtocolTest tests** (camel-netty-http, CAMEL-16718) by fixing the `uppercase()` processor to use String conversion instead of manual ByteBuf ref-count management, which caused a double-release. - **Keep 5 TLS 1.3 FTPS tests disabled** with accurate annotation — embedded Apache FtpServer does not support TLS 1.3. - **Update misleading `@Disabled` annotations** on 16 tests whose JIRAs are resolved but tests should remain disabled (csimple-joor code-gen limitations, olingo4 deprecated/Attic, xchange missing WireMock coverage). ## Details ### camel-ftp (17 files) The FTPS tests were blanket-disabled in 2021 via CAMEL-16784, leaving **zero FTPS integration test coverage**. The root cause was SSLv3 being disabled in modern JDKs. This PR: - Changes `AUTH_VALUE_SSL` from `"SSLv3"` to `"TLSv1.2"` - Updates all test URLs, `FTPSClient` constructors, and `SSLContextParameters` accordingly - Removes `@Disabled("CAMEL-16784")` from 7 parent test classes (+ 5 SSLContextParameters subclasses inherit the re-enabled test) - Adds `@EnabledIf(FtpsUtil#hasRequiredAlgorithms)` guard to `FileToFtpsExplicitSSLWithClientAuthIT` ### camel-netty-http (1 file) `ProxyProtocolTest` was disabled since CAMEL-16718 due to a ByteBuf double-release. The `uppercase()` processor manually called `body.release()` on a ByteBuf obtained via type conversion, but Camel also managed the lifecycle — causing a ref-count error. Fix: use `String` type conversion and let Camel handle ByteBuf lifecycle. ### Annotation updates (5 files) Updated `@Disabled` reasons on 16 tests across csimple-joor, olingo4, and xchange to accurately reflect why they remain disabled (previously referenced resolved JIRAs with no explanation). ## Test plan - [x] All 12 re-enabled FTPS tests pass locally - [x] All 15 re-enabled ProxyProtocolTest tests pass locally - [x] Both test suites verified stable over **100 consecutive iterations** (2700 total executions, 0 failures) - [x] All modules compile cleanly - [x] Code formatted with `mvn formatter:format impsort:sort` - [ ] CI green _Claude Code on behalf of Guillaume Nodet_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
