oscerd commented on code in PR #23083: URL: https://github.com/apache/camel/pull/23083#discussion_r3208390437
########## components/camel-telemetry/src/main/java/org/apache/camel/telemetry/decorators/AwsComprehendSpanDecorator.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.telemetry.decorators; + +import org.apache.camel.Endpoint; +import org.apache.camel.Exchange; +import org.apache.camel.telemetry.Span; + +public class AwsComprehendSpanDecorator extends AbstractSpanDecorator { + + static final String COMPREHEND_OPERATION = "operation"; + static final String COMPREHEND_LANGUAGE_CODE = "languageCode"; + static final String COMPREHEND_ENDPOINT_ARN = "endpointArn"; Review Comment: Done in 7e9fdfb — `AwsComprehendSpanDecorator` no longer emits the `endpointArn` tag, and the test was updated accordingly. You're right that the ARN embeds the account ID (e.g. `arn:aws:comprehend:us-east-1:123456789012:document-classifier-endpoint/MyEndpoint`), which is the same kind of identity disclosure we minimized away in earlier batches (IAM `userName`, KMS `keyId`, CloudTrail `username`, EKS `roleArn`). Comprehend now keeps `operation` and `languageCode`. _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
