gnodet opened a new pull request, #23130:
URL: https://github.com/apache/camel/pull/23130

   [CAMEL-23385](https://issues.apache.org/jira/browse/CAMEL-23385)
   
   Follow-up to #23121 — fixes three bugs introduced in the watch mode 
implementation:
   
   1. **Shadowed `running` variable prevents watch exit**: 
`ActionWatchCommand.doCall()` declared a local `AtomicBoolean running` that 
shadowed the field. The `waitForUserEnter()` method set the *field* to false, 
but the loop checked the *local* — so pressing Enter could never exit the watch 
loop.
   
   2. **`CamelRouteDiagramAction.waitForUserEnter()` never signals stop**: The 
override read a line from `lineReader` but never called `running.set(false)`, 
so even without the shadowing bug, the loop would continue after the user 
pressed Enter.
   
   3. **Terminal resource leak**: The terminal opened in `doCall()` was stored 
as a field but never closed. Wrapped in try/finally to ensure cleanup.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to