apupier commented on code in PR #23184:
URL: https://github.com/apache/camel/pull/23184#discussion_r3232735366


##########
core/camel-api/src/generated/java/org/apache/camel/ExchangeConstantProvider.java:
##########
@@ -168,7 +166,7 @@ public class ExchangeConstantProvider {
         MAP = map;
     }
 
-    public static @Nullable String lookup(String key) {
+    public static String lookup(String key) {

Review Comment:
   is it expected? it is not par tof the description of the PR



##########
core/camel-api/src/main/java/org/apache/camel/FluentProducerTemplate.java:
##########
@@ -76,9 +76,7 @@
  * <ul>
  * <li>throws {@link org.apache.camel.CamelExecutionException} if processing 
failed <i>during</i> routing with the
  * caused exception wrapped</li>
- * <li>The <tt>fault.body</tt> if there is a fault message set and its not 
<tt>null</tt></li>
- * <li>Either <tt>IN</tt> or <tt>OUT</tt> body according to the message 
exchange pattern. If the pattern is Out capable
- * then the <tt>OUT</tt> body is returned, otherwise <tt>IN</tt>.
+ * <li>The <tt>OUT</tt> body if the pattern is Out capable, otherwise 
<tt>IN</tt>.

Review Comment:
   Why removing the line on fault.body?



##########
core/camel-api/src/main/java/org/apache/camel/ProducerTemplate.java:
##########
@@ -45,9 +45,7 @@
  * <ul>
  * <li>throws {@link org.apache.camel.CamelExecutionException} if processing 
failed <i>during</i> routing with the
  * caused exception wrapped</li>
- * <li>The <tt>fault.body</tt> if there is a fault message set and its not 
<tt>null</tt></li>
- * <li>Either <tt>IN</tt> or <tt>OUT</tt> body according to the message 
exchange pattern. If the pattern is Out capable
- * then the <tt>OUT</tt> body is returned, otherwise <tt>IN</tt>.
+ * <li>The <tt>OUT</tt> body if the pattern is Out capable, otherwise 
<tt>IN</tt>.

Review Comment:
   Why the fault.body part is removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to