apupier commented on code in PR #23300:
URL: https://github.com/apache/camel/pull/23300#discussion_r3259821906
##########
components/camel-aws/camel-aws2-kinesis/src/main/java/org/apache/camel/component/aws2/kinesis/consumer/KinesisResumeStrategyConfiguration.java:
##########
@@ -60,7 +60,9 @@ public KinesisResumeStrategyConfigurationBuilder
withResumeCache(ResumeCache<?>
@Override
public KinesisResumeStrategyConfiguration build() {
KinesisResumeStrategyConfiguration result = new
KinesisResumeStrategyConfiguration();
- result.setResumeCache(resumeCache);
+ if (resumeCache != null) {
+ result.setResumeCache(resumeCache);
+ }
Review Comment:
I think it would be better that the
ResumeStartegyConfiguration.setResumeCache accepts null, as it was before.
Currently, we removed the possibility to set back resumecache to a null value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
