apupier commented on code in PR #23312:
URL: https://github.com/apache/camel/pull/23312#discussion_r3264243495
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AbstractReifier.java:
##########
@@ -208,6 +208,20 @@ public <T> T lookupByNameAndType(String name, Class<T>
type) {
if (EndpointHelper.isReferenceParameter(name)) {
answer = EndpointHelper.resolveReferenceParameter(camelContext,
name, type, false);
}
+ if (answer == null && route != null) {
+ // check local bean repository from route template context first
+ org.apache.camel.NamedNode routeNode = route.getRoute();
+ if (routeNode instanceof org.apache.camel.model.RouteDefinition) {
+ org.apache.camel.model.RouteDefinition routeDef =
(org.apache.camel.model.RouteDefinition) routeNode;
Review Comment:
use Pattern matching for "instance of"
https://next.sonarqube.com/sonarqube/coding_rules?open=java%3AS6201&rule_key=java%3AS6201
to avoid the following cast
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AbstractReifier.java:
##########
@@ -208,6 +208,20 @@ public <T> T lookupByNameAndType(String name, Class<T>
type) {
if (EndpointHelper.isReferenceParameter(name)) {
answer = EndpointHelper.resolveReferenceParameter(camelContext,
name, type, false);
}
+ if (answer == null && route != null) {
+ // check local bean repository from route template context first
+ org.apache.camel.NamedNode routeNode = route.getRoute();
+ if (routeNode instanceof org.apache.camel.model.RouteDefinition) {
+ org.apache.camel.model.RouteDefinition routeDef =
(org.apache.camel.model.RouteDefinition) routeNode;
Review Comment:
please use imports instead of FQCN (Fully Qualified Class Names)
##########
core/camel-core-reifier/src/main/java/org/apache/camel/reifier/AbstractReifier.java:
##########
@@ -208,6 +208,20 @@ public <T> T lookupByNameAndType(String name, Class<T>
type) {
if (EndpointHelper.isReferenceParameter(name)) {
answer = EndpointHelper.resolveReferenceParameter(camelContext,
name, type, false);
}
+ if (answer == null && route != null) {
+ // check local bean repository from route template context first
+ org.apache.camel.NamedNode routeNode = route.getRoute();
+ if (routeNode instanceof org.apache.camel.model.RouteDefinition) {
Review Comment:
please use imports instead of FQCN (Fully Qualified Class Names)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
