ppalaga commented on PR #23333: URL: https://github.com/apache/camel/pull/23333#issuecomment-4499157320
> ### Confirmed Issues > **1. (Medium) Typo in public API: `quarkusExtensioRegistryBaseUri` — missing 'n' in "Extension"** Fixed in 2c785b4 > **2. (Medium) Default value inconsistency for `fresh`** > > In `CamelJBangConstants.java`, the `FRESH` constant has `@Metadata(defaultValue = "true")`, which flows into the generated configuration metadata and documentation (`camel-jbang.adoc` shows `true` as the default). But in `MavenResolverMixin.java`, the actual CLI option has `defaultValue = "false"` and the field initializes to `false`. Users reading the docs will expect `--fresh` to default to `true`, but the runtime behavior defaults to `false`. Fixed in 2c785b4 the default everywhere is false. > **3. (Medium) Duplicate configuration property names in generated metadata/docs** > > The `camel-jbang-configuration-metadata.json` and `camel-jbang.adoc` now have **duplicate entries** with identical property names: > > * `camel.jbang.quarkusArtifactId` appears twice (once for "Quarkus Platform BOM", once for "Camel Quarkus Platform BOM") > * `camel.jbang.quarkusGroupId` appears twice > * `camel.jbang.quarkusVersion` appears twice > > These would conflict if set in `application.properties`. The Camel Quarkus-specific ones need distinct property names (e.g., `camel.jbang.camelQuarkusArtifactId`). Fixed in 2c785b4 > **4. (Low) Minor typos** > > * `"Whether to force usin fresh"` — missing 'g' in "using" (`CamelJBangConstants.FRESH` description, propagated to generated metadata and docs) Fixed in 2c785b4 > * `quarkusCamelPlatfromGav` — transposed 'r'/'o' in "Platform" (internal record field in `QuarkusHelper.java`) Fixed in 2c785b4 > **5. (Medium) Missing upgrade guide entry** > > Per project conventions, user-visible changes must be documented in `docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_21.adoc`. This PR introduces significant behavior changes (dynamic Quarkus resolution, new CLI options, deprecated `quarkusArtifactId`, removed hardcoded version). @davsclaus also requested this in the PR comments. Fixed in 2c785b4 More in 2c785b4: * Run the tests in camel-jbang-it locally and fixed what needed to get fixed. * The code fetching from `https://registry.quarkus.io` now throws and exception when the user passes `--fresh` and `--download=false` and recommends removing one or pass `--quarkus-version`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
