oscerd opened a new pull request, #23421: URL: https://github.com/apache/camel/pull/23421
## Backport of #23209 Cherry-pick of #23209 onto `camel-4.14.x`. **Original PR:** #23209 — CAMEL-23510: camel-jgroups - align Exchange header constant names with Camel naming convention **Original author:** @oscerd **Target branch:** `camel-4.14.x` **Jira:** [CAMEL-23510](https://issues.apache.org/jira/browse/CAMEL-23510) ### Manual adjustments during cherry-pick The cherry-pick required two manual resolutions because `camel-4.14.x` has diverged from `main`: - **`JGroupsConstants.java`** — `main` rewrote the `@Metadata(description = ...)` strings to use Java text blocks (`"""..."""`). The 4.14.x style still uses traditional `"..." +` string concatenation. The 4.14.x style is preserved; only the four header string values are renamed (`JGROUPS_*` → `CamelJGroups*`). - **Upgrade-guide entry** — the original PR added the entry to `docs/.../camel-4x-upgrade-guide-4_21.adoc`, which does not exist on `camel-4.14.x`. The same entry is added to `camel-4x-upgrade-guide-4_14.adoc` (in the "Upgrading from 4.14.5 to 4.14.6" window, after the existing `=== camel-cxf` section). Per the upgrade-guide backport policy in `CLAUDE.md`, a separate doc-sync PR will mirror the same entry into `camel-4x-upgrade-guide-4_14.adoc` on `main` to keep `main`'s 4.14 guide in sync with what ships on the maintenance branch. ### Changes - `components/camel-jgroups/src/main/java/org/apache/camel/component/jgroups/JGroupsConstants.java` — rename the four header string values to the `CamelJGroups*` convention (preserves 4.14.x concatenation style). - `docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_14.adoc` — add the upgrade-guide entry under the existing 4.14.5 → 4.14.6 window. - Regenerated metadata: `components/camel-jgroups/src/generated/resources/META-INF/.../jgroups.json`, `catalog/camel-catalog/src/generated/resources/.../jgroups.json`, `dsl/camel-endpointdsl/src/generated/java/.../JGroupsEndpointBuilderFactory.java`. ### Test plan - [x] `mvn clean install -DskipTests -Dquickly` from the worktree root — full reactor builds (BUILD SUCCESS, 7369 goals). - [x] Working tree clean after build (no uncommitted regenerated files). ### Original description > The Exchange header constants in `JGroupsConstants` were using raw uppercase string values (`JGROUPS_DEST`, `JGROUPS_SRC`, `JGROUPS_CHANNEL_ADDRESS`, `JGROUPS_ORIGINAL_MESSAGE`) that do not follow the Camel naming convention (`CamelXxxYyy`) used across the rest of the component catalog. > > The Java field names are unchanged; only the header string values have changed. > > Routes that reference the constants symbolically continue to work without changes. Routes that set the header by its literal string value must be updated to the new value (covered in the upgrade guide entry). --- _Claude Code on behalf of Andrea Cosentino_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
