oscerd opened a new pull request, #23454:
URL: https://github.com/apache/camel/pull/23454
## Summary
Renames the producer-side Exchange header string values in `GitHub2Constants`
from non-Camel prefixed values (`GitHubPullRequest`, `GitHubInResponseTo`,
`GitHubPullRequestHeadCommitSHA`, `GitHubIssueTitle`) to `CamelGitHub<Name>`,
following the convention used across the rest of the Camel component catalog
and matching the pattern established in CAMEL-23526 (`camel-cxf`),
CAMEL-23522
(`camel-mail`), CAMEL-23461 (`camel-aws-bedrock`), CAMEL-23532
(`camel-vertx-websocket` / `camel-atmosphere-websocket` / `camel-iggy`), and
CAMEL-23576 (`camel-jira`).
The Java field names (`GITHUB_PULLREQUEST`, `GITHUB_INRESPONSETO`,
`GITHUB_PULLREQUEST_HEAD_COMMIT_SHA`, `GITHUB_ISSUE_TITLE`) are unchanged so
routes referencing the constants symbolically continue to work; routes using
the literal string values must be updated (documented in the 4.21 upgrade
guide). The producer Javadocs that quote these header names are updated for
consistency.
## Scope note: camel-github removed
CAMEL-23582 originally scoped **both** `camel-github` and `camel-github2`.
The
deprecated `camel-github` component was **removed in Camel 4.21** (commit
`2eec2f35fae` "Remove camel-github component") before this rename could be
applied, so only `camel-github2` is addressed here.
## Already-compliant constants left unchanged
- The consumer-side constants (`GITHUB_COMMIT_AUTHOR`,
`GITHUB_COMMIT_COMMITTER`,
`GITHUB_COMMIT_SHA`, `GITHUB_COMMIT_URL`, `GITHUB_EVENT_PAYLOAD`) were
already
`Camel`-prefixed (`CamelGitHubCommitAuthor`, etc.).
- `GITHUB_CLIENT` (`github2Client`) is a registry-lookup key, not an Exchange
header, and is unchanged.
## Generated artifacts
- `components/camel-github2/.../github2.json` + catalog mirror
- `dsl/camel-endpointdsl/.../GitHub2EndpointBuilderFactory.java` — the
`gitHubPullRequestHeadCommitSHA()` accessor is renamed to
`gitHubPullRequestHeadCommitSha()` (SHA acronym casing); the other
accessors
keep their names but return the new `Camel`-prefixed values.
## Backports
- `camel-4.18.x`: `camel-github2` exists with the same legacy values —
backport
applies. Will be filed as a follow-up PR.
- `camel-4.14.x`: `camel-github2` does **not** exist on that branch — no
backport.
## Test plan
- [x] `mvn test` in `components/camel-github2` — passes
- [x] Module + catalog + endpointdsl built cleanly; only `camel-github2`
regen
artifacts included
- [x] Producer Javadocs quoting the header names updated to the new values
- [x] Upgrade guide entry added under `=== camel-github2`, cross-referencing
the `camel-github` removal
Tracker: CAMEL-23577
_Reported by Claude Code on behalf of Andrea Cosentino_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
