JinyuChen97 commented on PR #8692: URL: https://github.com/apache/camel-quarkus/pull/8692#issuecomment-4520214538
> Doesn't this change the original intent of the tests? The reason why the HTTP proxy tests were reaching out to an external resource, is because `localhost` was configured as 'noproxy' for test purposes. > > If we're worried about rate limits on Maven Central, maybe we just switch the URL to use the Google Maven mirror? > > https://maven-central.storage-download.googleapis.com/maven2 Thanks for the quick feedback! From my understand and the code base in camel CamelProxyRoutePlanner class, the test flow for nonProxy test seems determined by the PROXIED_URL = "https://localhost:xxxx......"; and the nonProxyHosts parameter in test request, if the target host is matched with nonProxyHosts parameter by exact match or wildcard matched, the request will not go through proxy, if they are not matched like the nonProxyHosts is 'example.com' but targethost is 'localhost' then it will need to go through the proxy server. The test here looks like is for testing different matching logics, whether external endpoint or internal endpoint seems is not the test purpose here? Please correct me if I'm wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
