Croway commented on code in PR #23531:
URL: https://github.com/apache/camel/pull/23531#discussion_r3304908626
##########
components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/OpenAIEndpoint.java:
##########
@@ -138,6 +138,7 @@ protected void doStop() throws Exception {
returnDirectTools.clear();
}
if (client != null) {
+ client.close();
Review Comment:
```
Closes this client, relinquishing any underlying resources.
This is purposefully not inherited from AutoCloseable because the client is
long-lived and usually should not be synchronously closed via
try-with-resources.
```
this is from the .close() java doc, should be safe without a try catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
