davsclaus commented on code in PR #23719: URL: https://github.com/apache/camel/pull/23719#discussion_r3349940226
########## docs/user-manual/modules/ROOT/pages/camel-4x-upgrade-guide-4_21.adoc: ########## @@ -20,6 +20,40 @@ It implies small differences listed https://github.com/whatap/java-grok#what-is- === camel-core +==== Simple language: internal builder classes reorganised + +The internal class `org.apache.camel.language.simple.SimpleExpressionBuilder` +(in `camel-core-languages`) has been removed. Its methods have been split across +seven domain-aligned builder classes: + +- `SimpleArithmeticExpressionBuilder` +- `SimpleCollectionExpressionBuilder` +- `SimpleConditionalExpressionBuilder` +- `SimpleStringExpressionBuilder` +- `SimpleSystemExpressionBuilder` Review Comment: **Blocking:** The class names listed here don't match the actual classes created by this PR. The upgrade guide lists: - `SimpleArithmeticExpressionBuilder` - `SimpleCollectionExpressionBuilder` - `SimpleConditionalExpressionBuilder` - `SimpleStringExpressionBuilder` - `SimpleSystemExpressionBuilder` - `SimpleTypeExpressionBuilder` - `SimpleUtilityExpressionBuilder` But the actual new classes are: - `CollectionExpressionBuilder` - `DateExpressionBuilder` - `FileExpressionBuilder` - `MathExpressionBuilder` - `MiscExpressionBuilder` - `OgnlExpressionBuilder` - `StringExpressionBuilder` Users following this guide would look for classes that don't exist. Please update the list to match the actual class names. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
