oscerd opened a new pull request, #23887:
URL: https://github.com/apache/camel/pull/23887

   # Description
   
   Per the CAMEL-23577 umbrella, this aligns the Exchange header constant 
*values* in `SalesforceEndpointConfig` with the project-wide 
`Camel<Component><Name>` naming convention, so they are governed by the default 
`HeaderFilterStrategy` (which only filters `Camel`/`camel`-prefixed headers). 
It follows the same shape as CAMEL-23576 (camel-jira), CAMEL-23578 
(camel-web3j), CAMEL-23597 (camel-solr) and the other sub-tasks.
   
   ## What changed
   
   - **39 producer-read header constants** in `SalesforceEndpointConfig` 
renamed to `CamelSalesforce<Name>` — for example `sObjectQuery` → 
`CamelSalesforceSObjectQuery`, `apexUrl` → `CamelSalesforceApexUrl`, and the 
`apexQueryParam.` prefix → `CamelSalesforceApexQueryParam.`. The Java field 
names are unchanged.
   - The **endpoint option spelling is unchanged** (for example 
`salesforce:query?sObjectQuery=...`) — it is bound to the `@UriParam` field 
name, not to these constants. Only the **header** name changes.
   - Updated the affected tests, the component documentation (a new note under 
*General Usage*), and added a 4.21 upgrade-guide entry (marked as a potential 
breaking change, with the full constant mapping table).
   
   ## Scope notes
   
   - **Excluded — configuration-only, never read from a message header:** 
`apiVersion`, `format`, `rawPayload`, `defaultReplayId`, `fallBackReplayId`, 
`initialReplayIdMap`, `replayPreset`, `pubSubDeserializeType`, 
`pubSubPojoClass`, `notFoundBehaviour`, `fallbackToLatestReplayId`.
   - **Excluded — intentional:** the Approval API `approval` / 
`approval.<property>` mechanism, whose endpoint-option and header spellings are 
intentionally identical and bound to the `approval` parameter name. Renaming 
only the header side would break that documented symmetry (same rationale as 
handling `camel-undertow`'s `websocket.*` external-contract prefix separately 
in CAMEL-23588). Left for separate consideration.
   
   ## Testing
   
   - `mvn clean install` on `camel-salesforce-component` — green, all unit 
tests pass.
   - No catalog / Endpoint-DSL regeneration results, because these constants 
are not `@Metadata` catalog headers (the catalog `headers` are declared in the 
separate `SalesforceConstants` and already follow the convention).
   
   ## Backports
   
   To follow for `camel-4.18.x` and `camel-4.14.x` (the component exists on 
both branches), with the matching 4_18 / 4_14 upgrade-guide entries doc-synced 
back to `main`.
   
   Tracker: https://issues.apache.org/jira/browse/CAMEL-23577
   
   ---
   _Claude Code on behalf of Andrea Cosentino_
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to