davsclaus commented on code in PR #23927:
URL: https://github.com/apache/camel/pull/23927#discussion_r3393732619
##########
core/camel-core/src/test/java/org/apache/camel/processor/DefaultConsumerBridgeErrorHandlerContinuedTest.java:
##########
@@ -48,10 +48,9 @@ public void testDefaultConsumerBridgeErrorHandlerContinued()
throws Exception {
getMockEndpoint("mock:onException").expectedMinimumMessageCount(1);
getMockEndpoint("mock:subroute").expectedMinimumMessageCount(1);
- // With continued(true), processing should continue after error
handling
- // However, since the consumer throws before creating a valid exchange,
- // mock:result won't receive messages
- getMockEndpoint("mock:result").expectedMessageCount(0);
+ // With continued(true), the exchange continues through the main route
after error handling,
+ // so mock:result should receive messages.
+ getMockEndpoint("mock:result").expectedMinimumMessageCount(1);
Review Comment:
This reverses the original CAMEL-22907 assertion which expected 0 messages
here, with the rationale that "the consumer throws before creating a valid
exchange". With `continued(true)`, the bridge error handler creates an
exchange, onException processes it, and `continued(true)` allows it to proceed
through the route to `mock:result`. The original `expectedMessageCount(0)` was
a race condition — it passed only when the mock assertion completed before the
continued exchange arrived.
The new assertion looks correct, but since it contradicts the original
test's explicit intent, confirmation from the CAMEL-22907 author would be
valuable.
##########
test-infra/camel-test-infra-tensorflow-serving/src/main/resources/org/apache/camel/test/infra/tensorflow/serving/services/container.properties:
##########
@@ -15,7 +15,7 @@
## limitations under the License.
## ---------------------------------------------------------------------------
tensorflow.serving.container=mirror.gcr.io/tensorflow/serving:2.19.1
-tensorflow.serving.container.aarch64=bitnami/tensorflow-serving:2.18.0
+tensorflow.serving.container.aarch64=mirror.gcr.io/bitnamilegacy/tensorflow-serving:2.19.1
Review Comment:
Minor: the `bitnamilegacy` namespace suggests this image may be deprecated
upstream. Worth verifying it has ongoing maintenance so this doesn't need
another fix soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
