davsclaus commented on code in PR #23980:
URL: https://github.com/apache/camel/pull/23980#discussion_r3404117027
##########
components/camel-ai/camel-openai/src/main/java/org/apache/camel/component/openai/McpToolConverter.java:
##########
@@ -49,14 +49,16 @@ private static ChatCompletionFunctionTool
convertTool(McpSchema.Tool tool) {
if (tool.inputSchema() != null) {
FunctionParameters.Builder paramsBuilder =
FunctionParameters.builder();
paramsBuilder.putAdditionalProperty("type",
Review Comment:
The production code correctly migrated to `Map<String, Object>` API here.
However, the corresponding tests (`McpToolConverterTest` and
`OpenAIProducerMcpMockTest`) still construct `McpSchema.JsonSchema` objects and
pass them through the deprecated `inputSchema(JsonSchema)` builder method.
Consider updating the tests to use `Map<String, Object>` directly to match this
production pattern and avoid reliance on deprecated APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
