orpiske commented on code in PR #23729:
URL: https://github.com/apache/camel/pull/23729#discussion_r3407661269
##########
components/camel-test/camel-test-junit6/src/main/java/org/apache/camel/test/junit6/TestExecutionConfiguration.java:
##########
@@ -163,7 +163,7 @@ public boolean isCreateCamelContextPerClass() {
* @return <tt>true</tt> per class, <tt>false</tt> per test.
*/
@Deprecated(since = "4.7.0")
- protected TestExecutionConfiguration
withCreateCamelContextPerClass(boolean createCamelContextPerClass) {
+ public TestExecutionConfiguration withCreateCamelContextPerClass(boolean
createCamelContextPerClass) {
Review Comment:
I need to take a look at the my chat history, because I think the reason why
I never removed this was indeed because it could break things on CEQ. I think,
the right approach is either one of:
1. Undo this deprecation notice and add a comment stating that this is
required for Quarkus or
2. Double check if it's not required in Camel Core and then, move what this
API call does to the Quarkus equivalent (if possible).
Option 1 might be easier, but 2 is likely a cleaner approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
