davsclaus commented on code in PR #24026: URL: https://github.com/apache/camel/pull/24026#discussion_r3412783699
########## dsl/camel-jbang/camel-jbang-container/readme.md: ########## @@ -0,0 +1,60 @@ +# Camel JBang container release process + +This folder contains all the scripts required to run the release process for Camel JBang containers. It is performed via `Makefile` which contains the configuration variable for each release version. + +The process is in charge to build, publish and verify images for the JVM and architectures provided in the configuration, for example: + +``` +JDK_VERSIONS = 17-jdk 21-jdk +ARCH_VERSIONS = amd64 arm64 +``` + +It also set the default container image for `amd64` architecture and the JDK defined in `OFFICIAL_IMAGE_VERSION` configuration variable. + +The process can be run from `main` branch as it is in charge to checkout the proper release tag version as part of the execution script. + +## Docker Hub staging setting + +The default configuration is set to publish on https://hub.docker.com/orgs/apache/repositories[Apache Docker Hub organization] Review Comment: Same AsciiDoc link syntax issue here: ```suggestion The default configuration is set to publish on [Apache Docker Hub organization](https://hub.docker.com/orgs/apache/repositories) ``` ########## dsl/camel-jbang/camel-jbang-container/readme.md: ########## @@ -0,0 +1,60 @@ +# Camel JBang container release process + +This folder contains all the scripts required to run the release process for Camel JBang containers. It is performed via `Makefile` which contains the configuration variable for each release version. + +The process is in charge to build, publish and verify images for the JVM and architectures provided in the configuration, for example: + +``` +JDK_VERSIONS = 17-jdk 21-jdk +ARCH_VERSIONS = amd64 arm64 +``` + +It also set the default container image for `amd64` architecture and the JDK defined in `OFFICIAL_IMAGE_VERSION` configuration variable. + +The process can be run from `main` branch as it is in charge to checkout the proper release tag version as part of the execution script. + +## Docker Hub staging setting + +The default configuration is set to publish on https://hub.docker.com/orgs/apache/repositories[Apache Docker Hub organization] + +If you want to perform a staging release, you need to change the `IMAGE_NAME ?= docker.io/apache/camel-jbang` to any other organization where you have privileges to push images. + +## Software required to release + +In order to release Camel JBang you may need certain software installed in the machine from where you're performing the release action. Most of the actions are scripted and may assume the presence of tools (in some case with specific version). Here a best effort list (may not be fully accurate): + +* Docker and DockerX tooling +* https://www.qemu.org/[QEMU] - required to emulate ARM64 build + +### Verify if your machine can build an ARM64 container image + +As suggested above, you may need to install some software to be able to build an ARM64 based image. You can verify that with: + +``` +docker buildx ls | grep arm +``` + +NOTE: if you don't list any available builder, if you're on Ubuntu, you can install quickly QEMU via `sudo apt-get install -y qemu qemu-user-static` and retry to list the ARM64 based builders afterward. + +## Stage images + +In order to perform a staging release, run: + Review Comment: This uses AsciiDoc link syntax (`url[text]`), but the file is Markdown — should be `[Apache Docker Hub organization](https://hub.docker.com/orgs/apache/repositories)`. Same issue on line 34 with the QEMU link: ```suggestion * [Docker](https://www.docker.com/) and DockerX tooling * [QEMU](https://www.qemu.org/) - required to emulate ARM64 build ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
