luigidemasi commented on PR #24065: URL: https://github.com/apache/camel/pull/24065#issuecomment-4728035577
@oscerd: > > **Blocking** > > * CI is red on `build (25)` at the _"Fail if there are uncommitted changes"_ gate. It looks like the regenerated user-manual mirror of the validator-plugin doc (`docs/user-manual/modules/ROOT/pages/camel-yaml-dsl-validator-maven-plugin.adoc`) wasn't committed — the module source copy under `dsl/camel-yaml-dsl/.../src/main/docs/` was edited but not its generated mirror. Re-running the validator-plugin doc generation and committing the result should clear it. It should be fixed now ✅ > **Minor** > > * The PR also carries an unrelated `camel yaml normalize` → `camel validate normalize` rename across ~6 files. It looks like a legitimate catch-up to the CLI rebrand, but it's outside [CAMEL-23775](https://issues.apache.org/jira/browse/CAMEL-23775)'s scope and isn't called out in the description — worth a one-line note for reviewers, or splitting out. the rename is tiny, legitimate, and partly generated/doc catch-up. Splitting it would add process overhead for a low-risk wording correction, I'll update the pr description for the reviewers. > * `newYamlDeserializationContext()` now calls `ctx.start()` eagerly so registry resolvers load up front. That seems _more_ correct than before, but it is a behavioral change in when registry resolvers are discovered — please confirm it's intended (the new tests do pass). Yes, this is intentional. Previously `YamlDeserializationContext.start()` was the place where registry-provided `YamlDeserializerResolver` instances were loaded, but the route loader did not explicitly start the context after creating it. With the new classpath discovery path, resolver discovery has to happen before parsing starts, otherwise a module-provided YAML step may be encountered before its resolver has been loaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
