ammachado commented on PR #24120: URL: https://github.com/apache/camel/pull/24120#issuecomment-4760601901
Withdrawing this PR. The review is correct on the substance. Two factual issues confirmed against the code: 1. The change was mislabeled as "lambda capture holders." The `int[]`/`boolean[]` values are passed by reference as parameters into `createNode()`; the only lambda (`tokens.removeIf`) does not reference them. 2. The new inline comment and `@param` additions described the Java mechanism rather than the domain intent, and the added tests largely duplicate existing coverage (e.g. `SimpleParserPredicateInvalidTest.testSimpleUnevenSingleQuote`, which additionally asserts the error index). On net value: `AtomicBoolean`/`AtomicInteger` as single-threaded mutable holders has been the established idiom in these parsers since 2012 and is self-documenting. Swapping it for single-element arrays is lateral churn in long-stable code with no clear readability or performance win, so this is not worth pursuing. Closing and resolving CAMEL-23798 as Won't Do. _Claude Code on behalf of Adriano Machado_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
