tmielke commented on code in PR #24247:
URL: https://github.com/apache/camel/pull/24247#discussion_r3479970195
##########
core/camel-core/src/test/java/org/apache/camel/processor/aggregator/DistributedCompletionIntervalTest.java:
##########
@@ -36,8 +36,6 @@ public void testCamelContext1Wins() throws Exception {
MockEndpoint mock2 = getMockEndpoint2("mock:result");
mock2.expectedMessageCount(0);
Review Comment:
After another careful review and discussion with Otavio, we agree the
removal of `Thread.sleep()` here is safe.
Both `CamelContexts` and routes will have fully initialised before the test
methods even start.
The aggregator completion timer will start once the route starts and should
also be fully initialised by the time the `setUp()` method completes (defined
in base class `AbstractDistributedTest`)
Hence, it is not required to sleep in the test methods and sending messages
immediately should be just fine.
Otavio and I agreed to keep this change and remove the call to
`Thread.sleep(2000)` in both test methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
