gnodet commented on PR #22524: URL: https://github.com/apache/camel/pull/22524#issuecomment-4837226484
_Claude Code on behalf of Alireza Esmaeili_ @apupier Good catch! I investigated why PR #24274's comment wasn't updated. **Root cause: artifact overwrite race condition with cancelled builds** The CI has two JDK matrix entries (17, 25) that both upload the `ci-comment` artifact with `overwrite: true`. Here's what happened for #24274: 1. **JDK 17 build** failed at 14:38:49 — but it ran long enough to generate `incremental-test-comment.md` and uploaded it 2. **JDK 25 build** was **cancelled** at 14:39:06 — the `incremental-build.sh` was killed before generating the comment file. The `if: always()` cleanup steps still ran and uploaded a `ci-comment` artifact containing **only** `pr-number` (no comment file) 3. Since JDK 25 finished 18 seconds **after** JDK 17, its empty artifact **overwrote** JDK 17's complete one 4. The commenter workflow downloaded the overwritten artifact and logged: `No comment file found, skipping` PR #24272 (kafka) worked fine because both JDK 17 and 25 succeeded — both generated the comment file, so the overwrite was harmless. **Fix:** I've updated the upload step to only upload (and overwrite) when `incremental-test-comment.md` actually exists. This way, a cancelled build can't clobber a completed build's artifact. Pushing the fix now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
