davsclaus commented on issue #8806:
URL: https://github.com/apache/camel-quarkus/issues/8806#issuecomment-4840426261
⏺ Quarkus sets profile on MainConfigurationProperties directly. So it does
use MainConfigurationProperties — not just DefaultConfigurationProperties. Let
me check if CamelMain then calls
configureMain.
Searched for 4 patterns (ctrl+o to expand)
⏺ So BaseMainSupport calls ProfileConfigurer.configureMain(), and Quarkus's
CamelMain extends MainCommandLineSupport extends MainSupport extends
BaseMainSupport. So Quarkus does go through
configureMain after all — via the BaseMainSupport parent class.
That means our changes are fine — we didn't remove anything from
configureMain that Quarkus needs. We just moved setTracingStandby to
configureCommon (which configureMain calls), and kept the
Main-only tracerConfig().withStandby(), errorRegistryConfig(), and
securityConfig() in configureMain.
Quarkus gets everything through the BaseMainSupport → configureMain →
configureCommon chain.
✻ Sautéed for 37s · 1 shell still running
❯ ok so Quarkus already supports this
⏺ Yes exactly. Quarkus inherits from BaseMainSupport which calls
ProfileConfigurer.configureMain(), so it already gets the full profile setup —
tracer standby, error registry, security policy,
and all the configureCommon dev features.
It's only Spring Boot that bypasses configureMain (it has its own
CamelAutoConfiguration bootstrap), which is why we needed to add the
configureCommon call and the individual
auto-configuration fixes there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
