ammachado commented on code in PR #24322:
URL: https://github.com/apache/camel/pull/24322#discussion_r3498949649
##########
dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/MonitorContext.java:
##########
@@ -43,7 +45,17 @@
*/
class MonitorContext {
Review Comment:
Good catch, this one was missed. Hint keys were meant to be theme-resolved
(the `accentBg()` javadoc even claimed to cover them), but the chip used a
hardcoded `HINT_KEY_STYLE` constant that bypassed `Theme` entirely. Worse,
being a `static final` it was frozen at class load, so it could never track a
runtime theme toggle.
Fixed in the latest commit: added a `#hint-key` token to
`dark.tcss`/`light.tcss` (black-on-orange, unchanged look in both themes) and a
`Theme.hintKey()` accessor, then migrated `MonitorContext` and all call sites
off the constant. The `accentBg()` javadoc is corrected and `ThemeTest` now
asserts the new token resolves exactly. Behavior is identical today (the chip
is black-on-orange in both modes), but it is now wired through the engine like
every other color.
_Claude Code on behalf of Adriano Machado_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
