davsclaus commented on code in PR #24412: URL: https://github.com/apache/camel/pull/24412#discussion_r3522693693
########## dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/TuiIcons.java: ########## @@ -0,0 +1,220 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.camel.dsl.jbang.core.commands.tui; + +import java.util.List; + +/** + * Single source of truth for emoji and symbolic icons used across the Camel TUI. + * <p/> + * Tab/menu icons use plain 2-column-wide emoji without VS16 variation selectors (see CAMEL-23818). Doctor and legacy + * status glyphs may still use mixed-width symbols until migrated. + */ +final class TuiIcons { + + // ---- Brand & runtime ---- + static final String CAMEL = "🐪"; + static final String SPRING_BOOT = "🍃"; Review Comment: Minor: `DEV_PROFILE = "🛠️"` and `WARN = "⚠️"` (lines 35, 39) contain VS16 variation selectors, while the class Javadoc says to use "plain 2-column-wide emoji without VS16". The `primaryTabEmojisHaveNoVariationSelector` test only checks `PRIMARY_TAB_ICONS`. These were pre-existing values being centralized — consider either stripping VS16 or adding a doc note that these are intentional exceptions. ########## dsl/camel-jbang/camel-jbang-plugin-tui/src/main/java/org/apache/camel/dsl/jbang/core/commands/tui/FilesBrowser.java: ########## @@ -117,7 +117,7 @@ private boolean loadDirectory(Path dir) { Review Comment: The `switch` in `fileType()` (line 315) now matches against `TuiIcons.CAMEL`, `TuiIcons.JAVA`, etc., but `TuiHelper.fileEmoji()` which produces the values being compared still returns raw emoji literals. Works because the values are identical, but a follow-up migrating `TuiHelper.fileEmoji()`/`fileEmojiByName()` to use `TuiIcons` would complete the centralization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
