gnodet commented on PR #24393:
URL: https://github.com/apache/camel/pull/24393#issuecomment-4881091797

   _Claude Code on behalf of Guillaume Nodet_
   
   Addressed all three Copilot review comments:
   
   **ReconnectTest `assertIsSatisfied(500)`**: Good catch — the `500` timeout 
was silently ignored when `expectedCount > 0`, because `doAssertIsSatisfied()` 
calls `waitForCompleteLatch()` which uses `resultWaitTime` (defaulting to a 
10-second wait). Fixed by calling `setResultWaitTime(500)` after each `reset()`.
   
   **MaxReconnectTest Awaitility wrapper (line 69)**: Agreed the Awaitility 
`pollDelay` wrapper was unnecessary for a zero-count mock. Replaced with a 
direct `mockEndpoint.assertIsSatisfied(2000)`.
   
   **MaxReconnectTest final assertion (line 76)**: Replaced 
`assertIsSatisfied(1000)` with `setAssertPeriod(1000)` + `assertIsSatisfied()` 
to re-verify after the delay and catch late deliveries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to