gnodet commented on PR #24442: URL: https://github.com/apache/camel/pull/24442#issuecomment-4891098658
_Claude Code on behalf of Christoph Deppisch_ @apupier You are absolutely right on all three comments. After thorough investigation: 1. **The `pollDelay + assertTrue(true)` pattern is functionally identical to `Thread.sleep`** — it just adds verbosity. Since the SamplingThrottler processor is fully synchronous (`callback.done(true); return true;`) and uses the `direct:` endpoint, all messages are fully processed before `sendBody()` returns. There is no async condition to poll for. 2. **The test is not actually flaky.** We ran the original test 100 times locally with zero failures. The JIRA ticket (CAMEL-23916) was created proactively based on the `Thread.sleep` code pattern, not from observed CI failures. There is no evidence of this test ever failing in CI. 3. **The `setResultWaitTime(100)` → Awaitility change is also equivalent** — with `direct:` being synchronous, all messages have already arrived at the mock by the time `assertIsSatisfied()` is called. The 100ms wait time was already a no-op effectively. Closing this PR as the changes provide no real benefit. Will also close CAMEL-23916 as "Won't Fix" since the test is not flaky. Thank you for the careful review — it was spot on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
