gnodet opened a new pull request, #24482: URL: https://github.com/apache/camel/pull/24482
_Claude Code on behalf of gnodet_ ## Summary Follow-up to #24475 — addresses review feedback from Copilot and @ammachado that landed after the original PR was merged. **Changes:** - **Handle null classloader** (Copilot): `Theme.class.getClassLoader()` can legally return `null` for bootstrap-loaded classes. Now null-checked before calling `getResourceAsStream()`, falling through to the TCCL fallback instead of throwing an NPE. - **Soften javadoc wording** (@ammachado suggestion #1): Changed from "guaranteed to have access" to accurately describe the fallback behavior, so a future reader doesn't strip the TCCL fallback as dead code. - **Revert `ConcurrentHashMap` to `HashMap`** (@ammachado suggestion #2): All `CACHE` access is already inside `synchronized` methods, so the concurrent map added no real safety — just a misleading signal. ## Test plan - [x] All 6 `ThemeTest` tests pass. - [x] `mvn formatter:format impsort:sort` produces no diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
